[FFmpeg-devel] Realmedia patch

[Michael Niedermayer]

On Tue, Aug 26, 2008 at 11:26:19AM +0200, Luca Abeni wrote:
> Hi,
> 
> Michael Niedermayer wrote:
> [...]
> >> Index: ffmpeg-svn/libavformat/rtp_internal.h
> >> ===================================================================
> >> --- ffmpeg-svn.orig/libavformat/rtp_internal.h	2008-08-24 21:34:30.000000000 -0400
> >> +++ ffmpeg-svn/libavformat/rtp_internal.h	2008-08-24 21:57:39.000000000 -0400
> >> @@ -146,5 +146,20 @@
> >>  
> >>  void av_register_rtp_dynamic_payload_handlers(void);
> >>  
> >> +/**
> >> + * Calculate the response (RealChallenge2 in the RTSP header) to the
> >> + * challenge (RealChallenge1 in the RTSP header from the Real/Helix
> >> + * server), which is used as some sort of client validation.
> >> + *
> >> + * @param response pointer to response buffer, it should be at least 41 bytes
> >> + *                 (40 data + 1 zero) bytes long.
> >> + * @param chksum pointer to buffer containing a checksum of the response,
> >> + *               it should be at least 9 (8 data + 1 zero) bytes long.
> >> + * @param challenge pointer to the RealChallenge1 value provided by the
> >> + *                  server.
> >> + */
> > 
> >> +void ff_rdt_calc_response_and_checksum(char *response, char *chksum,
> >> +                                       const char *challenge);
> > 
> > the array sizes are missing
> 
> BTW, I also believe that this does not belong to rtp_internal.h (probably,
> an rdt.h file should be created).

fine with me as well ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080826/9842c964/attachment.pgp>