[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [4/7] - G.729 core

[Michael Niedermayer]

On Sat, Aug 23, 2008 at 08:42:02PM +0700, Vladimir Voroshilov wrote:
> Updated after recent changes in SVN
[...]
> +/**
> + * minimum gain pitch value (3.8, Equation 47)
> + * 0.2 in (1.14)
> + */
> +#define SHARP_MIN                  3277
> +
> +/**
> + * maximum gain pitch value (3.8, Equation 47)
> + * (EE) This does not comply with the specification.
> + * Specification says about 0.8, which should be
> + * 13107 in (1.14), but reference C code uses
> + * 13017 (equals to 0.7945) instead of it.
> + */
> +#define SHARP_MAX                  13017

ok


[...]
> +    int16_t gain_pitch;         ///< (1.14) pitch gain of previous subframe (3.8) [SHARP_MIN ... SHARP_MAX]
[...]
> +    int16_t pitch_sharp;        ///< pitch sharpening of the previous frame

these 2 variables are redundant, one can be removed

[...]

> +        if(ctx->frame_erasure)
> +        {
> +            ctx->gain_pitch = FFMIN((29491 * ctx->gain_pitch) >> 15, 29491); // 0.9 (0.15)

> +            ctx->gain_code  = (8028 * ctx->gain_code) >> 13; // 0.98 in (2.13)

2007 >> 11


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080826/9f75fc93/attachment.pgp>