[FFmpeg-devel] Realmedia patch

[Ronald S. Bultje]

Hi Michael,

On Thu, Aug 21, 2008 at 12:05 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Aug 18, 2008 at 10:21:35AM -0400, Ronald S. Bultje wrote:
>>  /**
>>   * @returns 0 on success, <0 on error, 1 if protocol is unavailable.
>>   */
>>  static int
>> -make_setup_request (AVFormatContext *s, const char *host, int port, int protocol)
>> +make_setup_request (AVFormatContext *s, const char *host, int port,
>> +                    int protocol, RealSetupRequestData *real_data)
>>  {
>
> I think a const char *real_challenge would be enough no RealSetupRequestData
> seems needed

Changed.

>> +void
>> +ff_rdt_calc_response_and_checksum(char *response, char *chksum, char *challenge)
>
> the arguments should be const as appropriate and look like chksum[123] so
> the size of the arrays is clearly known

Also changed.

Attached patch implements only the RDT-compatible SETUP command, and
requires the previous patch that exports data_to_hex().

Ronald
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rtsp-setup.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080824/c6c7fa49/attachment.txt>