[FFmpeg-devel] [PATCH] Fix some typos in avfilter.h

Stefano Sabatini stefano.sabatini-lala
Sun Aug 24 22:52:25 CEST 2008

On date Sunday 2008-08-24 15:24:21 -0400, The Wanderer encoded:
> Stefano Sabatini wrote:
> > On date Saturday 2008-08-23 22:21:50 -0400, The Wanderer encoded:
>  >
> >> Michael Niedermayer wrote:
> >>> and the third is outright wrong and could lead serious confusion
> >>> (thats all IMHO of course)
> > 
> > Yes again, and I now see that my correction was outright wrong,
> > anyway the way the sentence is formulated leads naturally to
> > confusion, as I was reading it as:
> > 
> > And all the references of
> >     a and b,
> >     and a and b
> > will be deallocated.
> > 
> > so it seemed to me just a wrong repetition, so maybe some
> > reforumlation may improve its clearness.
> I can see what you're talking about. It read clearly enough to me, but
> it could certainly be made less potentially ambiguous, though I'm having
> a hard time of coming up with a way to do it without using uncommon
> grammatical forms - something like "Also deallocates a, b, and all
> references thereof.", which is technically correct but will seem awkward
> to many people.

What about
"Also all the references of a, b, and a and b themselves will be deallocated."

For what regards the second hunk:
"Therefore, we have the format list structure store a pointer..."
            we have the format list structure *to* store a pointer..." 

I know both forms are used, can you tell which is the more
correct? Also I think the direct form (preferred in the patch):
"the format list structure has to store..."
is clearer.

Sorry for the nitpicking, feel free to ignore this patch if you
think this discussion is just a timewaste.

FFmpeg = Fostering & Forgiving Meaningful Patchable Exciting Guide
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-some-avfilter-h-typos-01.patch
Type: text/x-diff
Size: 1525 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080824/2dac7647/attachment.patch>

More information about the ffmpeg-devel mailing list