[FFmpeg-devel] [RFC] lavc add const, code cleanup

[Reimar Döffinger]

On Sun, Aug 24, 2008 at 09:50:40PM +0200, Michael Niedermayer wrote:
> On Sun, Aug 24, 2008 at 09:10:12PM +0200, Reimar D?ffinger wrote:
> > I would be glad if the respective maintainers would apply whatever they
> > like.
> 
> i have a bad feeling about this going to work out

Me too, but I can always hope ;-)

[...]
> > @@ -1373,7 +1373,7 @@ static void reverse_dc_prediction(Vp3DecodeContext *s,
> >       * from other INTRA blocks. There are 2 golden frame coding types;
> >       * blocks encoding in these modes can only predict from other blocks
> >       * that were encoded with these 1 of these 2 modes. */
> > -    unsigned char compatible_frame[8] = {
> > +    static const uint8_t compatible_frame[8] = {
> >          1,    /* MODE_INTER_NO_MV */
> >          0,    /* MODE_INTRA */
> >          1,    /* MODE_INTER_PLUS_MV */
> 
> this is ok if the code never writes into these tables ...

I did try to check that, but I intend to have another look before
applying (somewhen in the next days when I find time).