[FFmpeg-devel] [PATCH] Fix some typos in avfilter.h

Stefano Sabatini stefano.sabatini-lala
Sun Aug 24 16:02:40 CEST 2008

On date Saturday 2008-08-23 22:21:50 -0400, The Wanderer encoded:
> Michael Niedermayer wrote:
> > On Sun, Aug 24, 2008 at 02:56:42AM +0200, Michael Niedermayer wrote:
> > 
> >> On Sat, Aug 23, 2008 at 11:23:45PM +0200, Stefano Sabatini wrote:
> >> 
> >>> Hi, as in subject.
> >>> 
> >>> I'm not sure for the second hunk.
> >> 
> >> So why do you include it?
> >> 
> >> patches arent being submitted as a test for them being correct,
> >> patches are submitted after the author is sure they are correct.
> This is not always the case. Sometimes patches are submitted as "I am
> proposing this change for consideration - what do people think about
> it?". In fact, it could be argued that *all* patches are submitted under
> that category, to one degree or another; certainly any "I will apply
> this in N days if no one objects" patches would seem to fit it.
> > btw in case anyone wonders
> > from the 3 hunks
> > the first fixes a missing char typo and likely correct
> > the second is unneeded

Yes but it sounded strange anyway at least to me, being myself a
non-native English speaker was the reason for which I was asking.

> > and the third is outright wrong and could lead serious confusion
> > (thats all IMHO of course)

Yes again, and I now see that my correction was outright wrong, anyway
the way the sentence is formulated leads naturally to confusion, as I
was reading it as:

And all the references of 
    a and b, 
    and a and b
will be deallocated.

so it seemed to me just a wrong repetition, so maybe some
reforumlation may improve its clearness. 

> Agreed on all three points. There is a bad grammar issue in the third
> hunk (beginning a sentence with "And" is almost never a good idea), but
> the patch as it stands doesn't even try to change that.

FFmpeg = Fiendish & Fast Multimedia Patchable Evangelical Gospel

More information about the ffmpeg-devel mailing list