[FFmpeg-devel] [PATCH] tcp.c/udp.c memleak?

Michael Niedermayer michaelni
Sun Aug 24 01:45:05 CEST 2008

On Sat, Aug 23, 2008 at 06:28:56PM -0400, Ronald S. Bultje wrote:
> > Its clear the line of code doesnt do nothing as the assert could trigger.
> > So why was this line addded, was it never needed?
> > has its need disapeared at some point?
> > Was it always nonsense?
> > If it was always nonsense then all code of the patch author should be
> > carefully reviewed again ...
> >
> > What looks strange is that this line was added in the same revission that
> > added url_split() there and that added the @ removing code in url_split()
> I just noticed, that patch is nonsensical. I suppose the functionality
> of that line in tcp.c was moved to url_split() but never removed from
> tcp.c; then he submitted the patch, we didn't see and there we go.
> You'll also notice the useless comments in that version of
> utils.c:url_split().
> Not sure how to figure out what other patches he submitted. "grep -r
> PETR ." is empty here. We should probably just remove the
> corresponding line from tcp.c...

svn log | grep ...

and feel free to remove the line if you are sure it is unneeded

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080824/b8b2d01b/attachment.pgp>

More information about the ffmpeg-devel mailing list