[FFmpeg-devel] [PATCH] AAC Encoder, Round 2

Michael Niedermayer michaelni
Sat Aug 23 22:28:03 CEST 2008

On Sat, Aug 23, 2008 at 06:31:30PM +0300, Kostya wrote:
> I'm back (feeling even worse than before but nm).
> Here is $subj is in a form of diff against FFmpeg SVN.

now the psy model:


> +/**
>   * Calculate Bark value for given line.
>   */
>  static inline float calc_bark(float f)
>  {
>      return 13.3f * atanf(0.00076f * f) + 3.5f * atanf((f / 7500.0f) * (f / 7500.0f));
>  }

why does vorbis_dec.c use a slightly different one?

except that, i think the previous reviews have not been dealt with yet.
That is the various suggestions for quality improvment should be tried
what is better should be adopted
Also everything that Gabriel Bouvign suggested should be tried.

I do not mind if we leave some of the harder things like viterbi based window
decission to after svn ci, but the majority of the things suggested should
be tried before the code is commited.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080823/9ab5678b/attachment.pgp>

More information about the ffmpeg-devel mailing list