[FFmpeg-devel] [PATCH] tcp.c/udp.c memleak?

[Michael Niedermayer]

On Sat, Aug 23, 2008 at 03:05:49PM -0400, Ronald S. Bultje wrote:
> Hi Michael,
> 
> On Sat, Aug 23, 2008 at 1:43 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > time for more stuff. This patch removes the check for "@" in hostname
> > for tcp.c, because url_split() already does that.
> 
> you forgot this one. :-). I've tested that even if auth is NULL, the @
> part is stripped correctly, so this code is never reached. Do I need
> to do additional testing?

no, but if you replace the line by an equivalent assert() iam ok with
it

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080823/e38683b9/attachment.pgp>