[FFmpeg-devel] [PATCH] tcp.c/udp.c memleak?

[Michael Niedermayer]

On Fri, Aug 22, 2008 at 06:10:47PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Fri, Aug 22, 2008 at 6:03 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Fri, Aug 22, 2008 at 05:26:45PM -0400, Ronald S. Bultje wrote:
> >> Hi Michael,
> >>
> >> On Thu, Aug 21, 2008 at 1:02 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Wed, Aug 20, 2008 at 11:09:27PM -0400, Ronald S. Bultje wrote:
> >> >> Hi Michael,
> >> >>
> >> >> On Wed, Aug 20, 2008 at 10:42 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> >> > On Wed, Aug 20, 2008 at 02:03:12PM -0400, Ronald S. Bultje wrote:
> >> >> >> Hi,
> >> >> >>
> >> >> >> tcpmemleak.patch: I think the malloc should go after the init &
> >> >> >> paramchecks otherwise the return in ff_network_init() could be a
> >> >> >> memleak. In tcp.c, I move the malloc down,
> >> >> >
> >> >> > i think it should be moved over all goto fail* which would allow
> >> >> > the fail case to be simplified
> >> >>
> >> >> Hm, ok, like $attached?
> >>
> >> What about the first patch?
> >
> > that mixes unrelated changes as well
> 
> Sorry, I thought you wanted that in the same patch. Here's just the
> move of ff_network_init() to prevent the memleak. The rest will come
> in small patches separately.

patch ok

though i still would like to see the malloc() moved down in tcp.c so the
av_free() becomes uneeded

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080823/1fc619c9/attachment.pgp>