[FFmpeg-devel] Realmedia patch

[Michael Niedermayer]

On Fri, Aug 22, 2008 at 10:06:17PM +0200, Luca Abeni wrote:
> Ronald S. Bultje wrote:
> [...]
> >> I think that we should only use standard tags here (and not the "RMFF",
> >> "OpaqueData", "ASMRuleBook", ... keywords used by real). Can you just
> >> call parse_sdp_a_line() in the final "else" case (without checking for
> >> any particular tag)? Then, you can check for the real tags in the
> >> rdt_parse_sdp_line() function.
> > 
> > So s/else if(..||..||..)/else/? Sure, no problem.
> 
> Yes... Does this work for you?
> Index: libavformat/rtsp.c
> ===================================================================
> --- libavformat/rtsp.c  (revision 14908)
> +++ libavformat/rtsp.c  (working copy)
> @@ -527,6 +527,12 @@
>               rtsp_parse_range_npt(p, &start, &end);
>               s->start_time= start;
>               s->duration= (end==AV_NOPTS_VALUE)?AV_NOPTS_VALUE:end-start; // AV_NOPTS_VALUE means live broadcast (and can't seek)
> +        } else if (s->nb_streams) {
> +            st = s->streams[s->nb_streams - 1];
> +            rtsp_st = st->priv_data;
> +            if (rtsp_st->dynamic_handler && rtsp_st->dynamic_handler->parse_sdp_a_line) {
> +                rtsp_st->dynamic_handler->parse_sdp_a_line(st, rtsp_st->dynamic_protocol_context, buf);
> +            }
>           }
>           break;
>       }
> (clearly, you have to move "AvgBitRate" handling in rdt_parse_sdp_line())
> 
> If yes, I'd say that this hunk should be committed (but let's hear if
> Michael and Luca B. are ok with this).

iam ok with it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080822/ccf61461/attachment.pgp>