[FFmpeg-devel] [PATCH] tcp.c/udp.c memleak?

Ronald S. Bultje rsbultje
Fri Aug 22 23:32:56 CEST 2008


On Thu, Aug 21, 2008 at 1:02 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Aug 20, 2008 at 11:09:27PM -0400, Ronald S. Bultje wrote:
>> I also attached a second which removes all useless comments in this
>> function. These comments are like "// url_split where the line that
>> the comments refers to in fact, yes really, you wouldn't believe it,
>> calls url_split. Also many other clueful comments in that func, I
>> killed them all. I also butchered a line which removes the
>> authentication from the returned hostname, because that same line is
>> already in url_split (even if auth is NULL) and rearranges some other
>> lines to make the function even smaller. (Maybe you want a new thread
>> for this or have it split for all the re-arrange thingies and
>> everything?)
> yes, please split it ...

Attached, the removing of comments is separated from the fixing up of
the checks. Since all cosmetic changes affect lines that are changed
already, I added those in these patches instead of in separate patches


[1]  (I understand that only lines of code unaffected by functional
changes need to be in a separate cosmetic patch; if lines of code are
being changed already, I'm allowed to change their cosmetics as well
in the same patch.)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: tcpremoveuselesscomments.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080822/b5df5d66/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: tcpfixchecks.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080822/b5df5d66/attachment.asc>

More information about the ffmpeg-devel mailing list