[FFmpeg-devel] Realmedia patch

[Ronald S. Bultje]

Hi Michael,

sorry, one more small question:

On Thu, Aug 21, 2008 at 12:05 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Aug 18, 2008 at 10:21:35AM -0400, Ronald S. Bultje wrote:
>> +    /* convert zres to ascii string */
>> +    for (i = 0; i < 16; i++) {
>> +        response[i * 2]     = hex_table[zres[i] >> 4];
>> +        response[i * 2 + 1] = hex_table[zres[i] & 0xf];
>> +    }
>
> grep hex */*.c shows that there are several existing data->hex converters
> thus this is duplicate

sdp.c:data_to_hex() seems cute, what header do you want me to export it into?

- create sdp.h
- in avformat.h (that's where avf_sdp_create(), the only non-static
function in sdp.c, is declared, but that's external API used by
ffserver, data_to_hex() would be internal-only API)
- in rtp_internal.h
- elsewhere, i.e. XYZ

I couldn't find other hex-to-data-converters, but there's 2
data-to-hex-converters, one in rtsp.c (data_to_hex(), inverse of
above) and one in lavc/opt.c, called hexchar2int, at some point I
could merge those (maybe into lavu/hex.[ch]? I'm just throwing out
random crap here :-) ).

Thanks,
Ronald