[FFmpeg-devel] [PATCH] Port AAC decoder to use ff_imdct_half and vector_fmul_window

Robert Swain robert.swain
Fri Aug 22 20:18:16 CEST 2008

2008/8/22 Michael Niedermayer <michaelni at gmx.at>:
> On Fri, Aug 22, 2008 at 03:03:44PM +0100, Robert Swain wrote:
>> Attached are:
>> 0001-Separate-IMDCT-and-windowing-into-imdct-windowing-a.patch
>> I thought the current layout of the code was quite difficult to look
>> at as it mixes imdct, windowing and buffer updates. I decided
>> separating them into clearer sections made the code more easy to
>> understand and think about.
>> 0002-Whitespace-cosmetics.patch
>> This cleans up alignment and such after 0001.
>> 0003-Use-imdct_half-and-fmul_window.-Reduce-buffer-sizes.patch
>> Does exactly what it says on the tin. :) I observe an ~10% performance
>> improvement after these patches.
>> Comments welcome as always. Benchmarks are below for this file.
> looks ok

Applied. Did you note the removal of the revers array and the other
array size reductions? Also the memset() and unnecessary addition of
0s has gone. :)

> btw, i think we should drop faad support ...

I'd like to leave it for the moment. As it has features we don't, it's
useful for testing.


More information about the ffmpeg-devel mailing list