[FFmpeg-devel] [PATCH] Generic part of frame multithreading

Michael Niedermayer michaelni
Fri Aug 22 00:28:13 CEST 2008

On Fri, Aug 22, 2008 at 12:23:04AM +0300, Uoti Urpala wrote:
> On Thu, 2008-08-21 at 17:10 +0200, Michael Niedermayer wrote:
> > using void* successfully requires the user to understand the internal buffer
> > handling so he doesnt loose his pointers, these problems are not worth the
> > merely hypothetical gain of being more generic.
> Yes you need to be more careful if you use void * with allocated memory.
> But you do need something like that if you have more than 64 bits of
> data per frame. And in that case not having support for void * only adds
> even _more_ complexity. You can't make all user data fit into one data
> type by not supporting the others. You're not helping reduce complexity,
> you're only burying your head in the sand and denying that complexity
> exists.

Please dont troll.
If you know of a specific case where the existing system is insufficient
you can tell us so it can be considered. If not theres no point in generically
telling us if X then Y with a X that isnt true ...

> > > > of course if you do want a union of double and int64_t then iam not opposed
> > > > to approve a patch
> > > 
> > > What would you need the patch for? Seems like a trivial change.
> > 
> > Iam not planing to implement your feature request for you, if you want it
> > send a patch that passes review.
> What would you expect from a patch except the obvious changes (which
> should take no longer to write from scratch than review and apply from a
> patch)?

conform to the patch submission guidlines, policy and common sense ...
that may or may not boil down to not breaking compilation with any currently
supported compiler ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080822/9a7e7a25/attachment.pgp>

More information about the ffmpeg-devel mailing list