[FFmpeg-devel] [PATCH] Generic part of frame multithreading

Michael Niedermayer michaelni
Wed Aug 20 23:37:10 CEST 2008

On Wed, Aug 20, 2008 at 10:23:31PM +0300, Uoti Urpala wrote:
> On Wed, 2008-08-20 at 21:00 +0200, Michael Niedermayer wrote:
> > > mplayer counts frame delay using avctx->has_b_frames, which works for  
> > > h264 and doesn't work with this. ffplay counts delay by adding pts to  
> > > frames in get_buffer, which works with this but might not work with  
> > > h264, because of the frame num gap code. I thought about making avctx- 
> > >  >delay accurate for decoding too, which should solve all this.
> > 
> > mplayer is violating lavc API ...
> > IIRC ive rejected the use of has_b_frames back then when uoti suggested it
> You remember things backwards. The preliminary version of -correct-pts
> used buffer callbacks to count the number of buffered frames, and it was
> you who suggested using has_b_frames instead.

I do remember rejecting the even more broken 
"callbacks to count the number of buffered frames" and i suspect i told you
back then that the timestamps should be given to the decoder to reorder them.
Maybe you rejected this and i then suggested to use has_b_frames, but if my
guess (and this is only a guess) is true it would really be more a
"least broken solution within the constraints" not a "working solution"


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080820/1c13f622/attachment.pgp>

More information about the ffmpeg-devel mailing list