[FFmpeg-devel] I have discovered why many MinGW installs can no longer build ffmpeg

[Dominik 'Rathann' Mierzejewski]

On Wednesday, 20 August 2008 at 09:46, Chris Cormie wrote:
[...]
> I've also got a patch for configure that catches the 3.79.1 bug and 
> warns the developer (below.) Could this be considered for testing and 
> merging in?

Cosmetic review below.

> 
> Regards,
> Chris Cormie
> 
> Index: configure
> ===================================================================
> --- configure	(revision 14784)
> +++ configure	(working copy)
> @@ -221,7 +221,7 @@
>   solving the problem.
>   EOF
>       fi
> -    rm -f $TMPC $TMPE $TMPH $TMPO $TMPS $TMPSH
> +    rm -f $TMPC $TMPE $TMPH $TMPO $TMPS $TMPSH $TMPM
>       exit 1
>   }
> 
> @@ -592,6 +592,13 @@
>   EOF
>   }
> 
> +check_make(){
> +    log check_make "$@"
> +    cat >$TMPM
> +    log_file $TMPM
> +    check_cmd make -f $TMPM
> +}
> +
>   require(){
>       name="$1"
>       header="$2"
> @@ -1124,6 +1131,7 @@
>   TMPO="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}.o"
>   TMPS="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}.S"
>   TMPSH="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}.sh"
> +TMPM="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}.mak"
> 
>   check_cflags -fasm
>   check_cflags -std=c99

Vertical align.

> @@ -1262,6 +1270,7 @@
>           SLIBNAME_WITH_MAJOR='$(SLIBPREF)$(FULLNAME).$(LIBMAJOR)$(SLIBSUF)'
>           FFSERVERLDFLAGS=-Wl,-bind_at_load
>           objformat="macho"
> +        enabled x86_64 && objformat="macho64"
>           ;;
>       mingw32*)
>           target_os=mingw32
> @@ -1561,6 +1570,7 @@
>       enabled_all x86_64 shared && append YASMFLAGS "-DPIC"
>       case "$objformat" in
>           elf) enabled debug && append YASMFLAGS "-g dwarf2" ;;
> +        macho64)              append YASMFLAGS "-DPIC -DPREFIX" ;;
>           *)                    append YASMFLAGS "-DPREFIX"  ;;
>       esac
>       check_yasm "pabsw xmm0, xmm0" && enable yasm

Stray hunks? Unrelated and already in SVN IIRC.

Regards,
R.

-- 
MPlayer http://mplayerhq.hu | Livna http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan