[FFmpeg-devel] [PATCH] E-AC-3 decoder, round 3

[Michael Niedermayer]

On Tue, Aug 19, 2008 at 07:43:31PM -0400, Justin Ruggles wrote:
> Michael Niedermayer wrote:
> > On Tue, Aug 19, 2008 at 06:54:35PM -0400, Justin Ruggles wrote:
> >> Hi,
> >>
> >> Thanks for the review.
> >>
> >> Michael Niedermayer wrote:
> >>> On Sun, Aug 17, 2008 at 07:30:26PM -0400, Justin Ruggles wrote:
> >>>> Hi,
> >>>>
> >>>> Here is a new patch to complete support for E-AC-3 decoding within the
> >>>> current AC-3 decoder.  It will be followed up by a cosmetic commit to
> >>>> indent and align.
> >>>>
> >>>> -Justin
> >>>>
> >>> [...]
> >>>> @@ -533,10 +547,27 @@
> >>>>      }
> >>>>  }
> >>>>  
> >>>> +static void get_transform_coeffs_ch(AC3DecodeContext *s, int blk, int ch,
> >>>> +                                    mant_groups *m)
> >>>> +{
> >>>> +    if (!s->channel_uses_aht[ch]) {
> >>>> +        ac3_get_transform_coeffs_ch(s, ch, m);
> >>>> +    } else {
> >>>> +        /* if AHT is used, mantissas for all blocks are encoded in the first
> >>>> +           block of the frame. */
> >>>> +        int bin;
> >>>> +        if (!blk)
> >>>> +            ff_eac3_get_transform_coeffs_aht_ch(s, ch);
> >>> am i blind? or where is this function, i cannot find it in this patch
> >>> nor in svn
> >> oops! I forgot to svn add eac3dec.c.  I have attached the whole file
> >> here.  It would be applied in the same commit with the rest of these
> >> changes (minus the part you said to commit separately).
> > 
> > does any of the changes i ok-ed depend on eac3dec.c ?
> > if not you could commit them and resubmit what is left + eac3dec.c
> 
> Well, sort of.  I could apply all the parts OKed so far, but I would
> have to comment out the 2 calls to functions which are in eac3dec.c and
> leave out the part which actually detects the frame as being E-AC-3.

fine
every part commited moves us a step closer to full EAC3 support

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080820/f0892609/attachment.pgp>