[FFmpeg-devel] Help commiting ok-ed parts of soc students

[Michael Niedermayer]

On Tue, Aug 19, 2008 at 01:20:26PM -0300, Ramiro Polla wrote:
> Hi Michael,
> 
> Michael Niedermayer wrote:
> > If someone could help commit ok -ed hunks of patches from SOC students that
> > would be appreciated.
> 
> Could you please not omit any part of the patch in your incremental 
> reviews? It makes applying them easier, since then we just have to go 
> through the review and check that the diff for the OKed - or + hunks are 
> the same. If a hunk is [...]'d it's harder to know what happened or 
> what's in the middle.

sorry, ive noticed the same problem when i commited the ok-ed parts from a
past patch by zhentan. (though your explanation is somewhat unclear)

ill be more carefull what i snip aroun ok-ed parts. Still snipping whole
hunks wont make a difference as the result is still a valid patch and
could thus as well have been the original patch.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080819/c4b122d1/attachment.pgp>