[FFmpeg-devel] [PATCH] split mdec.c from mpeg12.c

Diego Biurrun diego
Tue Aug 19 03:22:28 CEST 2008

On Tue, Aug 19, 2008 at 02:20:56AM +0200, Diego Biurrun wrote:
> Here is a little refactoring patch that moves mdec.c to a proper
> separate file that can be conditionally compiled instead of #including
> it from mpeg12.c.
> --- libavcodec/mpeg12.c	(revision 14829)
> +++ libavcodec/mpeg12.c	(working copy)
> @@ -152,7 +151,7 @@
> -static void init_vlcs(void)
> +void ff_init_vlcs(void)

Should this function be marked av_cold (in a separate patch)?  It is
only called from the mdec.c/mpeg12.c init functions, which are av_cold

> @@ -620,7 +619,7 @@
> -static inline int decode_dc(GetBitContext *gb, int component)
> +inline int ff_decode_dc(GetBitContext *gb, int component)

I am being told that non-static inline functions can be problematic.
There are two possible solutions:

- Move the function to a header file,
- remove the inline keyword.

Aurelien did the latter when splitting off wmv2.c from msmpeg4.c.


More information about the ffmpeg-devel mailing list