[FFmpeg-devel] Realmedia patch

[Michael Niedermayer]

On Mon, Aug 18, 2008 at 10:21:35AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> I lost count of how many I've done, but since I didn't receive review
> on the last ones I thought I'd just post whatever svn diff gives me
> after my recent updates.

ahh so i can drop 3 mails from my list :)

[...]

> Index: ffplay.c
> ===================================================================
> --- ffplay.c	(revision 14060)
> +++ ffplay.c	(working copy)
> @@ -1735,6 +1735,7 @@
>      if(thread_count>1)
>          avcodec_thread_init(enc, thread_count);
>      enc->thread_count= thread_count;
> +    ic->streams[stream_index]->discard = AVDISCARD_DEFAULT;
>      switch(enc->codec_type) {
>      case CODEC_TYPE_AUDIO:
>          is->audio_stream = stream_index;
> @@ -1829,6 +1830,7 @@
>          break;
>      }
>  
> +    ic->streams[stream_index]->discard = AVDISCARD_ALL;
>      avcodec_close(enc);
>      switch(enc->codec_type) {
>      case CODEC_TYPE_AUDIO:
> @@ -1939,6 +1941,7 @@
>  
>      for(i = 0; i < ic->nb_streams; i++) {
>          AVCodecContext *enc = ic->streams[i]->codec;
> +        ic->streams[i]->discard = AVDISCARD_ALL;
>          switch(enc->codec_type) {
>          case CODEC_TYPE_AUDIO:
>              if ((audio_index < 0 || wanted_audio_stream-- > 0) && !audio_disable)

ok (yes just the change to ffplay.c)

1minute review of rest below, ill do a real review after soc assumin ive
not forgotten by then 

[...]
> +    rt->real_stream = !!real_data;
> +    rt->no_streams_chosen_yet = 1;
> +#if 0
> +    if (real_data) {
> +        snprintf(cmd, sizeof(cmd),
> +                 "SET_PARAMETER %s RTSP/1.0\r\n"
> +                 "Subscribe: ",
> +                 s->filename);
> +        for (i = 0; i < rt->nb_rtsp_streams; i++)
> +            ff_rdt_subscribe_for_bandwidth(rt->rtsp_streams[i]->dynamic_protocol_context, cmd, sizeof(cmd), i, 40000);
> +        av_strlcat(cmd, "\r\n", sizeof(cmd));
> +        rtsp_send_cmd(s, cmd, reply, NULL);
> +        if (reply->status_code != RTSP_STATUS_OK) {
> +            err = AVERROR_INVALIDDATA;
> +            goto fail;
> +        }
> +#if 0
> +        snprintf(cmd, sizeof(cmd),
> +                 "SET_PARAMETER %s RTSP/1.0\r\n"
> +                 "SetDeliveryBandwidth: Bandwidth=128000;BackOff=0\r\n",
> +                 s->filename);
> +        rtsp_send_cmd(s, cmd, reply, NULL);
> +        if (reply->status_code != RTSP_STATUS_OK) {
> +            err = AVERROR_INVALIDDATA;
> +            goto fail;
> +        }
> +#endif
> +    }
> +#endif
>      return 0;
>  

random disabled code

[...]
}
> +            }
> +            
> +            ff_rdt_subscribe_for_bandwidth(
> +                rt->rtsp_streams[i]->dynamic_protocol_context,
> +                cmd, sizeof(cmd), i, rule_nr);

trailing whitespace

[...]

> +#ifdef ASM_RULEBOOK_DEBUG
> +        printf("Condition: %s [%d] %d\n", expr->id, expr->cond, expr->val);
> +#endif

hmpf, print() ? 
ifdeffery :(

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080818/ee150c4f/attachment.pgp>