[FFmpeg-devel] [PATCH] change the order of params for av_init_random()

[Måns Rullgård]

Justin Ruggles <justinruggles at bellsouth.net> writes:

> $subject
>
> includes lavu minor version bump.
>
> -Justin
>
> Index: libavutil/avutil.h
> ===================================================================
> --- libavutil/avutil.h	(revision 14819)
> +++ libavutil/avutil.h	(working copy)
> @@ -35,7 +35,7 @@
>  #define AV_VERSION(a, b, c) AV_VERSION_DOT(a, b, c)
>  
>  #define LIBAVUTIL_VERSION_MAJOR 49
> -#define LIBAVUTIL_VERSION_MINOR  9
> +#define LIBAVUTIL_VERSION_MINOR 10
>  #define LIBAVUTIL_VERSION_MICRO  0
>  
>  #define LIBAVUTIL_VERSION_INT   AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
> Index: libavutil/random.c
> ===================================================================
> --- libavutil/random.c	(revision 14819)
> +++ libavutil/random.c	(working copy)
> @@ -36,7 +36,7 @@
>  #define LOWER_MASK 0x7fffffff /* least significant r bits */
>  
>  /** initializes mt[AV_RANDOM_N] with a seed */
> -void av_init_random(unsigned int seed, AVRandomState *state)
> +void av_init_random(AVRandomState *state, unsigned int seed)

This requires a major version bump, since it breaks ABI.

Rather than going through all that hassle, I'd be tempted to stick to
the old order, even if it is less intuitive.

-- 
M?ns Rullg?rd
mans at mansr.com