[FFmpeg-devel] [PATCH] Fix for rc_eq memory leak

[Michael Niedermayer]

On Thu, Jul 31, 2008 at 11:21:45AM -0700, Art Clarke wrote:
> Stefano submitted a fix for the rc_eq setting bug earlier this month:
> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2008-July/049805.html
> 
> As he pointed out, this introduced a memory leak on AVFormatContext:rc_eq.
> 
> This patch fixes one cause of leaking this in the libav* libraries (for well
> behaved applications): closing an input stream.
> 
> There isn't an easy fix for programs that allocate their own AVFormatContext
> objects (e.g. for output).  Folks will have to fix their sources for that.
> 
> Tests with both ffmpeg and vlideshow pass @ 100%, and leak is visible before
> fix and not after fix.

patch rejected, possibly exploitable freeing of pointers that have not been
allocated

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080816/1d1b4d9a/attachment.pgp>