[FFmpeg-devel] [PATCH] Move lpc utility code from flacenc.c to lpc.{c|h}

[Jai Menon]

Hi,

On Saturday 16 Aug 2008 10:44:58 am Jai Menon wrote:
> Hi,
>
> On Friday 15 Aug 2008 4:44:35 pm Michael Niedermayer wrote:
> > On Fri, Aug 15, 2008 at 03:07:12PM +0530, Jai Menon wrote:
> > > Hi,
> > >
> > > On Friday 15 Aug 2008 2:58:15 pm Ramiro Polla wrote:
> > > > Hi,
> > > >
> > > > On Fri, Aug 15, 2008 at 3:14 AM, Jai Menon <realityman at gmx.net> wrote:
> > > > > Attached patch moves a few functions from the flac encoder so that
> > > > > it can be shared by the alac encoder.
> > > >
> > > > For MLP I used the entire lpc_calc_coefs(). Is that not ok for alac?
> > >
> > > No, currently the order estimation does not require such extensive
> > > code. It doesn't really help with compression or speed. A simpler
> > > approach is used instead.
> >
> > please also use lpc_calc_coefs()
> >
> > > > And the functions should be prefixed with ff_, and lpc.c be made as
> > > > an svn cp ; svn diff from flacenc.c
> > >
> > > ...and is there any particular reason/advantage for using 'svn cp'?
> > > Just curious.
> >
> > "svn blame" cannot relate lines of code to authors&commits if svn cp
> > hasnt been used
>
> I made the changes and created a new patch. I used svn cp this time and the
> resulting patch was quite large (to put it mildly). I wanted to check if
> this is normal before posting it. It comes in at around 94kb ;-)
>

I'll just post it in case this is okay.
I used svn cp to copy flacenc.c to lpc.c and lpc.h and made the required 
changes. I will add the order estimation to lpc_calc_coefs if this is fine.

Regards,

Jai Menon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: move_shared_lpc_code.patch
Type: text/x-diff
Size: 96454 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080816/3395ec57/attachment.patch>