[FFmpeg-devel] [PATCH] Move lpc utility code from flacenc.c to lpc.{c|h}

Michael Niedermayer michaelni
Fri Aug 15 13:14:35 CEST 2008


On Fri, Aug 15, 2008 at 03:07:12PM +0530, Jai Menon wrote:
> Hi,
> 
> On Friday 15 Aug 2008 2:58:15 pm Ramiro Polla wrote:
> > Hi,
> >
> > On Fri, Aug 15, 2008 at 3:14 AM, Jai Menon <realityman at gmx.net> wrote:
> > > Attached patch moves a few functions from the flac encoder so that it can
> > > be shared by the alac encoder.
> >
> > For MLP I used the entire lpc_calc_coefs(). Is that not ok for alac?
> >
> 
> No, currently the order estimation does not require such extensive code. It 
> doesn't really help with compression or speed. A simpler approach is used 
> instead.

please also use lpc_calc_coefs()


> 
> > And the functions should be prefixed with ff_, and lpc.c be made as an
> > svn cp ; svn diff from flacenc.c
> >
> 
> ...and is there any particular reason/advantage for using 'svn cp'?
> Just curious.

"svn blame" cannot relate lines of code to authors&commits if svn cp hasnt
been used

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080815/902cfea4/attachment.pgp>



More information about the ffmpeg-devel mailing list