[FFmpeg-devel] [PATCH] WMAPRO packet parser

[Michael Niedermayer]

On Thu, Aug 14, 2008 at 10:59:15PM +0200, Sascha Sommer wrote:
> Hi,
> 
> On Donnerstag, 14. August 2008, Michael Niedermayer wrote:
> > On Thu, Aug 14, 2008 at 08:16:38PM +0200, Sascha Sommer wrote:
> > > Hi,
> > >
> > > attached patch adds support for a wma3 decoder skeleton and packet
> > > parser. Basically less than what I expected to do during SOC but before I
> > > can continue with the bitstream parsing after SOC I will first have to
> > > reverse engineer and understand more of the inner parts of the codec.
> >
> > well, if you do not have a functional decoder then i think there is only
> > limited sense in commiting any of this into svn ...
> > anyway, review below, also please see wma/wmadec.c the likely existing
> > similarities could help reverse engeneering and understanding. And
> > factorizing common code out would be required anyway ...
> >
> 
> Yes the question will be how similar it will be in the end. I think the 
> decoder has to at least to be able to decode some samples before one can 
> decide how the wma 1, 2, 3 decoders should be split.

yes, this is also why i am thinking its too early to commit any of it to
svn, we simply cannot clean it up / factorize it because we do not yet see
the "whole picture" ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080814/232594c3/attachment.pgp>