[FFmpeg-devel] [RFC][PATCH] move _ISOC9X_SOURCE

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Wed, Aug 13, 2008 at 08:20:55PM +0200, Michael Niedermayer wrote:
>> On Wed, Aug 13, 2008 at 06:04:10PM +0100, M?ns Rullg?rd wrote:
>> > 
>> > Michael Niedermayer wrote:
>> > > Hi
>> > >
>> > > Currently -D_ISOC9X_SOURCE is in common.mak which makes it unavailable
>> > > to tests in configure patch below moves it into configure.
>> > > If this is approved then ill also post one that adds the -Dposix there.
>> > >
>> > > Index: common.mak
>> > > ===================================================================
>> > > --- common.mak	(revision 14508)
>> > > +++ common.mak	(working copy)
>> > > @@ -18,7 +18,7 @@
>> > >  ALLFFLIBS = avcodec avdevice avfilter avformat avutil postproc swscale
>> > >
>> > >  CFLAGS := -DHAVE_AV_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE \
>> > > -          -D_ISOC9X_SOURCE -I$(BUILD_ROOT_REL) -I$(SRC_PATH) $(OPTFLAGS)
>> > > +          -I$(BUILD_ROOT_REL) -I$(SRC_PATH) $(OPTFLAGS)
>> > >
>> > >  %.o: %.c
>> > >  	$(CC) $(CFLAGS) $(LIBOBJFLAGS) -c -o $@ $<
>> > 
>> > OK
>> > 
>> > > Index: configure
>> > > ===================================================================
>> > > --- configure	(revision 14508)
>> > > +++ configure	(working copy)
>> > > @@ -963,6 +963,7 @@
>> > >  vhook="default"
>> > >
>> > >  # build settings
>> > > +CFLAGS='-D_ISOC9X_SOURCE'
>> > 
>> > Unless I am mistaken, this will override with CFLAGS from the
>> > environment.
>> 
>> ok, ive applied it with add_cflags
>
> Heres a patch that adds POSIX_C_SOURCE
> compiles & passes make test
>
> Index: configure
> ===================================================================
> --- configure	(revision 14739)
> +++ configure	(working copy)
> @@ -974,7 +974,7 @@
>  vhook="default"
>
>  # build settings
> -add_cflags '-D_ISOC99_SOURCE '
> +add_cflags '-D_ISOC99_SOURCE -D_POSIX_C_SOURCE=199309'

Still no need for quotes.

-- 
M?ns Rullg?rd
mans at mansr.com