[FFmpeg-devel] [RFC][PATCH] move _ISOC9X_SOURCE

[Måns Rullgård]

Michael Niedermayer wrote:
> Hi
>
> Currently -D_ISOC9X_SOURCE is in common.mak which makes it unavailable
> to tests in configure patch below moves it into configure.
> If this is approved then ill also post one that adds the -Dposix there.
>
> Index: common.mak
> ===================================================================
> --- common.mak	(revision 14508)
> +++ common.mak	(working copy)
> @@ -18,7 +18,7 @@
>  ALLFFLIBS = avcodec avdevice avfilter avformat avutil postproc swscale
>
>  CFLAGS := -DHAVE_AV_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE \
> -          -D_ISOC9X_SOURCE -I$(BUILD_ROOT_REL) -I$(SRC_PATH) $(OPTFLAGS)
> +          -I$(BUILD_ROOT_REL) -I$(SRC_PATH) $(OPTFLAGS)
>
>  %.o: %.c
>  	$(CC) $(CFLAGS) $(LIBOBJFLAGS) -c -o $@ $<

OK

> Index: configure
> ===================================================================
> --- configure	(revision 14508)
> +++ configure	(working copy)
> @@ -963,6 +963,7 @@
>  vhook="default"
>
>  # build settings
> +CFLAGS='-D_ISOC9X_SOURCE'

Unless I am mistaken, this will override with CFLAGS from the
environment.

Unrelated to the move, the defined symbol should be _ISOC99_SOURCE.
_ISOC9X_SOURCE was used by old versions of glibc before C99 was
finalised (and thus the year unknown), and is only supported for
compatibility.  I don't remember why the X version is used here.

>  SHFLAGS='-shared -Wl,-soname,$$(@F)'
>  VHOOKSHFLAGS='$(SHFLAGS)'
>  FFSERVERLDFLAGS=-Wl,-E
> @@ -1664,7 +1665,6 @@
>  # test for C99 functions in math.h
>  for func in llrint lrint lrintf round roundf; do
>      check_exec <<EOF && enable $func || disable $func
> -#define _ISOC9X_SOURCE  1
>  #include <math.h>
>  int main(void) { return ($func(3.999f) > 0)?0:1; }
>  EOF

OK

-- 
M?ns Rullg?rd
mans at mansr.com