[FFmpeg-devel] [PATCH] Split common code for MLP to mlp.[ch].

Michael Niedermayer michaelni
Wed Aug 13 16:14:17 CEST 2008

On Wed, Aug 13, 2008 at 10:14:51AM -0300, Ramiro Polla wrote:
> On Wed, Aug 13, 2008 at 10:13 AM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
> > Hello,
> >
> > I replied to this e-mail with two sets of big patches and it was too
> > big for the ML. I'm sending them again separately.
> >
> > On Wed, Aug 13, 2008 at 9:38 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> SSOn Wed, Aug 13, 2008 at 12:38:07AM -0300, Ramiro Polla wrote:
> >>> Hello,
> >>>
> >>> Attached patches remove common code from the MLP encoder in the SoC
> >>> repo and the decoder (and the parser) and puts it in common files.
> >>>
> >>> To commit, the split to mlp.[ch] would be made with svn cp from
> >>> mlpdec.c. I attached them as the resulting file to easy reviewing (or
> >>> is it better to have the diffs to mlpdec.c?).
> >>
> >> you could just attach both they are both usefull for reviewing
> >
> > I'm attaching them as diffs again. One for each file, but to be
> > committed all at once. What changed is that I removed the duplicate
> > comment for both checksum functions in mlp.h. Also I copied with the
> > */ in the same line, since that's how it is in mlpdec.
> >
> > I'll post a followup to this reply with the second set of patches.
> And here they are. The difference between the previous ones is that
> they have mlp_parse_init call a function in mlp_parser.c which in turn
> calls the common function in mlp.c. This way we can avoid #include'ing
> avcodec.h in mlp.h. It's attached as mlp_parser_2.c.diff,
> mlp_2.c.diff, and mlp_2.h.diff. mlpdec.c.diff is the same as the
> previous e-mail.

too large iam not going to review this, the patch should be against the
previous approved version.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080813/1c807f4f/attachment.pgp>

More information about the ffmpeg-devel mailing list