[FFmpeg-devel] [RFC] Modify the ff* tools -version output

[Stefano Sabatini]

On date Tuesday 2008-08-12 14:36:58 +0200, Michael Niedermayer encoded:
> On Tue, Aug 12, 2008 at 12:15:25AM +0200, Stefano Sabatini wrote:
[...]
> > > > OK, what about this:
> > > > FFmpeg SVN-r14692
> > > > libavutil   49.9.0 / 49.9.0
> > > > libavcodec  51.64.0 / 51.64.0
> > > > libavformat 52.20.0 / 52.20.0
> > > > libavdevice 52.1.0 / 52.1.0
> > > > libavfilter 0.1.0 / 0.1.0
> > > > ?
> > > 
> > > vertical align
> > 
> > patch #02:
> > FFmpeg SVN-r14695
> > libavutil     49.9.0 / 49.9.0
> > libavcodec   51.64.0 / 51.64.0
> > libavformat  52.20.0 / 52.20.0
> > libavdevice   52.1.0 / 52.1.0
> > libavfilter    0.1.0 / 0.1.0
> > 
> > patch #03 (slightly more bloated):
> > FFmpeg SVN-r14695
> > libavutil     49.9.0 /   49.9.0
> > libavcodec   51.64.0 /  51.64.0
> > libavformat  52.20.0 /  52.20.0
> > libavdevice   52.1.0 /   52.1.0
> > libavfilter    0.1.0 /    0.1.0
> 
> what about
> 
> libavutil    49. 9. 0 /  49. 9. 0
> libavcodec   51.64. 0 /  51.64. 0
> libavformat  52.20. 0 /  52.20. 0
> libavdevice  52. 1. 0 /  52. 1. 0
> libavfilter   0. 1. 0 /   0. 1. 0
> 
> ?
> maybe easier to make ...

FFmpeg version SVN-r14710, Copyright (c) 2000-2008 Fabrice Bellard, et al.
  configuration: ...
  libavutil version: 49.9.0
  libavcodec version: 51.64.0
  libavformat version: 52.20.0
  libavdevice version: 52.1.0
  libavfilter version: 0.1.0
  built on Aug 12 2008 15:36:24, gcc: 4.2.3 20071014 (prerelease) (Debian 4.2.2-3)
FFmpeg SVN-r14710
libavutil    49. 9. 0 /  49. 9. 0
libavcodec   51.64. 0 /  51.64. 0
libavformat  52.20. 0 /  52.20. 0
libavdevice  52. 1. 0 /  52. 1. 0
libavfilter   0. 1. 0 /   0. 1. 0

> [...]
> > Index: cmdutils.c
> > ===================================================================
> > --- cmdutils.c	(revision 14695)
> > +++ cmdutils.c	(working copy)
> > @@ -201,13 +201,6 @@
> >      fprintf(stderr, "%s version " FFMPEG_VERSION ", Copyright (c) %d-2008 Fabrice Bellard, et al.\n",
> >              program_name, program_birth_year);
> >      fprintf(stderr, "  configuration: " FFMPEG_CONFIGURATION "\n");
> > -    fprintf(stderr, "  libavutil version: " AV_STRINGIFY(LIBAVUTIL_VERSION) "\n");
> > -    fprintf(stderr, "  libavcodec version: " AV_STRINGIFY(LIBAVCODEC_VERSION) "\n");
> > -    fprintf(stderr, "  libavformat version: " AV_STRINGIFY(LIBAVFORMAT_VERSION) "\n");
> > -    fprintf(stderr, "  libavdevice version: " AV_STRINGIFY(LIBAVDEVICE_VERSION) "\n");
> > -#if ENABLE_AVFILTER
> > -    fprintf(stderr, "  libavfilter version: " AV_STRINGIFY(LIBAVFILTER_VERSION) "\n");
> > -#endif
> >      fprintf(stderr, "  built on " __DATE__ " " __TIME__);
> >  #ifdef __GNUC__
> >      fprintf(stderr, ", gcc: " __VERSION__ "\n");
> > @@ -216,14 +209,22 @@
> >  #endif
> >  }
> 
> rejected, we need to have the version in the output in bugreports

See that, but just to make my point: that information may be deduced
by the SVN revision number, so it's redundant and leads to code
duplication.

New patch attached, regards.
-- 
FFmpeg = Furious & Fostering Mind-dumbing Portable Earthshaking Game
-------------- next part --------------
A non-text attachment was scrubbed...
Name: change-version-04.patch
Type: text/x-diff
Size: 1261 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080812/455d94c7/attachment.patch>