[FFmpeg-devel] Patch for "non monotone timestamp" error

[Michael Niedermayer]

On Mon, Aug 11, 2008 at 10:27:51AM +0200, Diep Ho wrote:
> The following test in utils.c (compute_pkt_fields) is inadequate:
> 
>     if (delay &&
>         pc && pc->pict_type != FF_B_TYPE)
>         presentation_delayed = 1

no, this test is correct.


> 
> Would it be something like the following patch? Idea is that the

no the patch is just broken


> presentation is delayed when we end up with the pattern BP or BI.
> Otherwise, the presentation is not delayed. 
[...]
> I made a regression test. And what it gives me looks like this:
> 
> ret: 0 st: 0 dts:0.000000 pts:0.000000 pos:9216 size:9779 flags:1
>  ret: 0 st:-1 ts:-1.000000 flags:0
> -ret: 0 st: 0 dts:0.000000 pts:-102481911520608.625000 pos:9216
> size:9779 flags:1
> +ret: 0 st: 0 dts:0.000000 pts:0.000000 pos:9216 size:9779 flags:1
>  ret: 0 st:-1 ts:1.894167 flags:1
> -ret: 0 st: 0 dts:1.440000 pts:-102481911520608.625000 pos:135509
> size:11796 flags:1
> +ret: 0 st: 0 dts:1.440000 pts:1.440000 pos:135509 size:11796 flags:1
>  ret: 0 st: 0 ts:0.788333 flags:0
> -ret: 0 st: 0 dts:0.960000 pts:-102481911520608.625000 pos:86934
> size:10792 flags:1
> +ret: 0 st: 0 dts:0.960000 pts:0.960000 pos:86934 size:10792 flags:1
>  ret:-1 st: 0 ts:-0.317500 flags:1
>  ret:-1 st:-1 ts:2.576668 flags:0
> ...........
> 
> Does it mean that some wrong pts has been fixed with that patch?

no it means the patch broke something.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080811/145063a9/attachment.pgp>