[FFmpeg-devel] [PATCH] Eliminate -dc option from ffmpeg.c options

[Stefano Sabatini]

On date Saturday 2008-08-09 04:28:14 +0200, Michael Niedermayer encoded:
> On Fri, Aug 08, 2008 at 02:48:57PM -0700, Baptiste Coudurier wrote:
> > Hi,
> > 
> > Stefano Sabatini wrote:
> > > Hi all,
> > > 
> > > this seems unnecessary since it may be set using AVOptions.
> > > 
> > > Also I honestly cannot understand the -8 logic, but it seems to me
> > > plain wrong/misleading.
> > > 
> > 
> > Not at all, everybody express MPEG-2 (at least) DC precision in bits, so
> > you say 9/10/11 bits for dc 1/2/3.
> > 
> > This change command line usage and Im against it for now, some more
> > advanced AVOption system like eval() possibility would be better I think.
> 
> hmm, i think having command line options and internal variables do very
> different things could be confusing.
> 
> We could just make intra_dc_precision have 8,9,10,11 as value instead of
> 1/2/3 this would IMHO be the cleanest solution but would have to be
> done under #if VERSION with the next major version bump ...

Like this?

Regards.
-- 
FFmpeg = Fiendish Fast Merciless Pitiful Everlasting Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: deprecate-dc-opt-00.patch
Type: text/x-diff
Size: 1287 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080809/62773377/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dc-as-bits-of-precision-00.patch
Type: text/x-diff
Size: 1842 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080809/62773377/attachment-0001.patch>