[FFmpeg-devel] [PATCH] FFV1 speed tweaks

Michael Niedermayer michaelni
Sat Aug 9 04:19:45 CEST 2008

On Fri, Aug 08, 2008 at 07:34:01PM -0600, Jason Garrett-Glaser wrote:
> > The change to cur_sample and the sign handling seem independant. They should
> > be in seperate and benchmarked patches.
> > I have no choice but to reject such combined patches (this isnt the first ...),
> > and iam affraid this could make you angry which is not what i want at all.
> > Its a matter of less than 5 min to split this and running a benchmark 3 times
> > which each should barely take a minute with a short file.
> > Combining several changes and benchmarking them together leads to chunks of
> > code being commited that are slower then the original ...
> Oh, I can split it.  I already benchmarked each change as I made it
> though; on my system each change independently improved performance.

Iam a little surprised that increasing 3 variables and decreasing 1
is faster than adding 1 variable to them
Besides this, the parts against which noone had objections are fine if
they are commited well split and the commits contains precisse benchmark

Besides, your patch was mangled, tools/unwrap-diff could fix it though but
its an extra step. i suspect your MUA decided to line wrap the patch ...


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080809/a378f8b3/attachment.pgp>

More information about the ffmpeg-devel mailing list