[FFmpeg-devel] [PATCH] Eliminate -dc option from ffmpeg.c options

Stefano Sabatini stefano.sabatini-lala
Sat Aug 9 00:10:12 CEST 2008


On date Friday 2008-08-08 23:16:47 +0200, Michael Niedermayer encoded:
> On Fri, Aug 08, 2008 at 10:30:25PM +0200, Stefano Sabatini wrote:
> > Hi all,
> > 
> > this seems unnecessary since it may be set using AVOptions.
> 
> i think we have no regression test for -dc, if so
> please add -dc to one of the mpeg2 tests and update the checksums
> if the regression tests then pass with your patch then the patch is ok

They can't pass because ffmpeg changes the value using this transform:
value_passed_to_the_encoder = input_value - 8

(go figure...)

with the patch the transform would be:
value_passed_to_the_encoder = input_value

Anyway I'm going to modify the test, then I'll post an updated patch.

Regards.
-- 
FFmpeg = Foolish and Furious Multimedia Proud Earthshaking Goblin




More information about the ffmpeg-devel mailing list