[FFmpeg-devel] [PATCH] DAUD PCM sign fix [was: [PATCH] PCM regression tests]

Reimar Doeffinger Reimar.Doeffinger
Tue Aug 5 16:24:56 CEST 2008

On Tue, Aug 05, 2008 at 11:28:43PM +1000, pross at xvid.org wrote:
> The DAUD PCM encoder is buggy; it currently fetches values outside of
> the ff_reverse[256] array when input sample values are < 0. Patch enclosed.

IMO do it as it is done for decoding instead: by adding a "& 0xff" to the first
case (there is no problem for the second case).
Or alternatively cast the value instead of the pointer, esp. since IMO samples should
be made const, and that gets really annoying then (even better use a local
uint16_t variable).

More information about the ffmpeg-devel mailing list