[FFmpeg-devel] [PATCH] change AC3 to AC-3

Diego Biurrun diego
Sun Aug 3 16:38:48 CEST 2008

On Sun, Aug 03, 2008 at 09:58:55AM -0400, Justin Ruggles wrote:
> Diego Biurrun wrote:
> > On Sat, Aug 02, 2008 at 11:54:27PM -0400, Justin Ruggles wrote:
> >> This is a cosmetic patch to change all "AC3" and "ac3" to "AC-3". It
> >> also changes "E-AC3", "EAC3", etc... to "E-AC-3".
> > 
> > I wonder why you did not commit this directly?  You are the maintainer
> > of all those files.  All of this looks OK to me.  Since you posted a
> > patch, you will now get a review ;)
> I'm not the maintainer of ALL the files in question, only some of them.

You are listed as maintainer of ac3*.  Anyway, I think it is safe to
commit such things directly.

> I didn't bother to nitpick existing comments, but I will follow your
> suggestions.

If I change a comment line or similar to fix a typo, I try to address
all the issues it might have in one fell swoop.  This reduces the
clutter of nitpickish commits to a minimum.


More information about the ffmpeg-devel mailing list