[FFmpeg-devel] [PATCH] change AC3 to AC-3

[Diego Biurrun]

On Sat, Aug 02, 2008 at 11:54:27PM -0400, Justin Ruggles wrote:
> 
> This is a cosmetic patch to change all "AC3" and "ac3" to "AC-3". It
> also changes "E-AC3", "EAC3", etc... to "E-AC-3".

I wonder why you did not commit this directly?  You are the maintainer
of all those files.  All of this looks OK to me.  Since you posted a
patch, you will now get a review ;)

> --- libavcodec/aac_ac3_parser.c	(revision 14516)
> +++ libavcodec/aac_ac3_parser.c	(working copy)
> @@ -1,5 +1,5 @@
>  /*
> - * Common AAC and AC3 parser
> + * Common AAC and AC-3 parser

Lowercase this while you're at it.

> --- libavcodec/ac3dec.h	(revision 14516)
> +++ libavcodec/ac3dec.h	(working copy)
> @@ -1,5 +1,5 @@
>  /*
> - * Common code between AC3 and E-AC3 decoder
> + * Common code between AC-3 and E-AC-3 decoder

ditto

> @@ -21,7 +21,7 @@
>  
>   * @file ac3.h
> - * Common code between AC3 and E-AC3 decoder.
> + * Common code between AC-3 and E-AC-3 decoder.

ditto

> --- libavcodec/aac_ac3_parser.h	(revision 14516)
> +++ libavcodec/aac_ac3_parser.h	(working copy)
> @@ -1,5 +1,5 @@
>  /*
> - * Common AAC and AC3 parser prototypes
> + * Common AAC and AC-3 parser prototypes

ditto

> --- libavcodec/ac3tab.c	(revision 14516)
> +++ libavcodec/ac3tab.c	(working copy)
> @@ -21,7 +21,7 @@
>  
>   * @file ac3tab.c
> - * tables taken directly from AC3 spec.
> + * tables taken directly from AC-3 spec.

from the, capitalize

> --- libavcodec/ac3.c	(revision 14516)
> +++ libavcodec/ac3.c	(working copy)
> @@ -1,5 +1,5 @@
>  /*
> - * Common code between AC3 encoder and decoder
> + * Common code between AC-3 encoder and decoder

lowercase

> @@ -21,7 +21,7 @@
>  
>   * @file ac3.c
> - * Common code between AC3 encoder and decoder.
> + * Common code between AC-3 encoder and decoder.

ditto

> --- libavcodec/ac3.h	(revision 14516)
> +++ libavcodec/ac3.h	(working copy)
> @@ -1,5 +1,5 @@
>  /*
> - * Common code between AC3 encoder and decoder
> + * Common code between AC-3 encoder and decoder

ditto

> @@ -21,7 +21,7 @@
>  
>   * @file ac3.h
> - * Common code between AC3 encoder and decoder.
> + * Common code between AC-3 encoder and decoder.

ditto

> --- libavcodec/ac3dec_data.c	(revision 14516)
> +++ libavcodec/ac3dec_data.c	(working copy)
> @@ -21,7 +21,7 @@
>  
>   * @file ac3dec_data.c
> - * tables taken directly from AC3 spec.
> + * tables taken directly from AC-3 spec.

see above

> --- libavcodec/ac3enc.c	(revision 14516)
> +++ libavcodec/ac3enc.c	(working copy)
> @@ -1,5 +1,5 @@
>  /*
> - * The simplest AC3 encoder
> + * The simplest AC-3 encoder

lowercase

> @@ -21,7 +21,7 @@
>  
>   * @file ac3enc.c
> - * The simplest AC3 encoder.
> + * The simplest AC-3 encoder.

lowercase, drop period

> --- libavformat/mpegenc.c	(revision 14516)
> +++ libavformat/mpegenc.c	(working copy)
> @@ -234,7 +234,7 @@
>  
> -                    /* special case for private streams (AC3 use that) */
> +                    /* special case for private streams (AC-3 use that) */

useS

> --- libavformat/nutenc.c	(revision 14516)
> +++ libavformat/nutenc.c	(working copy)
> @@ -814,7 +814,7 @@
>  #elif defined(CONFIG_LIBMP3LAME)
>      CODEC_ID_MP3,
>  #else
> -    CODEC_ID_MP2, /* AC3 needs liba52 decoder */
> +    CODEC_ID_MP2, /* AC-3 needs liba52 decoder */
>  #endif

This is no longer true, something needs to get updated..

Diego