[FFmpeg-devel] [RFC] lavc/ffmpeg sample_fmt implementation

pross at xvid.org pross
Sat Aug 2 07:09:55 CEST 2008


On Fri, Aug 01, 2008 at 09:31:20PM +0200, Michael Niedermayer wrote:
> On Sat, Aug 02, 2008 at 12:21:04AM +1000, pross at xvid.org wrote:
> > On Thu, Jul 31, 2008 at 06:39:12PM +0200, Michael Niedermayer wrote:
> > > On Fri, Aug 01, 2008 at 12:02:12AM +1000, pross at xvid.org wrote:
> > > > On Wed, Jul 30, 2008 at 10:09:02PM +0200, Michael Niedermayer wrote:
> > > > > On Mon, Jul 28, 2008 at 10:23:29PM +1000, pross at xvid.org wrote:
> > > > > > On Sun, Jul 27, 2008 at 11:00:05PM +0200, Michael Niedermayer wrote:
> > > > > > > On Sun, Jul 27, 2008 at 06:17:48PM +1000, pross at xvid.org wrote:
> > > > > > > > On Sat, Jul 26, 2008 at 01:08:09AM +1000, pross at xvid.org wrote:
> > > > > > > > > Hi.
> > > > > > > > > 
> > > > > > > > > This patch adds sample_fmt conversion support to lavc (and ffmpeg).
> > > > > > > > 
> > > > > > > > Round two patches enclosed.
> > > > > > > > 
> > > > > > 
> > > > > > Round three.
> > > > > > 
> > 
> > Round four. FFplay patch included as well.

> 
> 
> > Index: ffmpeg.c
> > ===================================================================
> > --- ffmpeg.c	(revision 14495)
> > +++ ffmpeg.c	(working copy)
> > @@ -257,6 +257,8 @@
> >      /* audio only */
> >      int audio_resample;
> >      ReSampleContext *resample; /* for audio resampling */
> 
> > +    int audio_reformat;
> > +    AVAudioConvert *reformat_ctx;
> 
> couldnt reformat_ctx!= NULL be used instead of audio_reformat ?

Agree.

> [...]
> 
> >  {
> >      AVPacket *pkt = &is->audio_pkt;
> > +    AVCodecContext *dec= is->audio_st->codec;
> >      int n, len1, data_size;
> >      double pts;
> 
> this and the related changes are ok but they are a seperate simplification and
> should be commited seperately from the audioconvert stuff.

Yes.

I've been reminded that decoders, such as mlpdec, may not fully decide on the
output sample_fmt until after AVCodec->init() call. The current FFmpeg patch
does not handle this case. I've revised the patch, again.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sfmt_ffmpeg-r2.diff
Type: text/x-diff
Size: 6280 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080802/5c12b7c9/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080802/5c12b7c9/attachment.pgp>



More information about the ffmpeg-devel mailing list