[FFmpeg-devel] [PATCH] Fill unspecified AVCodec long_name fields

Stefano Sabatini stefano.sabatini-lala
Sun Apr 27 12:47:14 CEST 2008


On date Saturday 2008-04-26 18:55:33 +0200, Diego Biurrun encoded:
> On Sat, Apr 26, 2008 at 01:00:56PM +0200, Stefano Sabatini wrote:
[...]
> > --- libavcodec/ffv1.c	(revision 12974)
> > +++ libavcodec/ffv1.c	(working copy)
> > @@ -1035,5 +1035,6 @@
> >      .pix_fmts= (enum PixelFormat[]){PIX_FMT_YUV420P, PIX_FMT_YUV444P, PIX_FMT_YUV422P, PIX_FMT_YUV411P, PIX_FMT_YUV410P, PIX_FMT_RGB32, -1},
> > +    .long_name= "FF Video Codec 1 (an experimental lossless codec)"
> 
> Hmmm, the multimedia wiki claims that the name is "FFmpeg codec #1".

Ok changed to that, also I removed the part between parenthesis.
[...] 
> > --- libavcodec/rpza.c	(revision 12974)
> > +++ libavcodec/rpza.c	(working copy)
> > @@ -283,4 +283,5 @@
> >      CODEC_CAP_DR1,
> > +    .long_name = "Quicktime Video (RPZA)",
> 
> QuickTime video (RPZA)
> 
> Are you sure this name is correct?

Changed to: "QuickTime video (RPZA)", I found this reference to the
(joking) meaning of RPZA (Road Pizza):
http://www.mackido.com/EasterEggs/QuickTime.html

so it chould change to:
"QuickTime Road Pizza video",

Thanks for the huge review, new patch attached.

I also downcased some other instances of "Audio/Video" (for example im
MPEG Audio layer ...), and changed consistently:

Real {Audio|Video} version X.0 --> Real{Audio|Video} X.0

which seems more used (not sure if it is better though).

Regards.
-- 
FFmpeg = Fucked and Foolish MultiPurpose EniGma
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-missing-long-names-04.patch
Type: text/x-diff
Size: 62147 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080427/84f9db2f/attachment.patch>



More information about the ffmpeg-devel mailing list