[FFmpeg-devel] [PATCH] mp3on4 heavy cleanup

[Baptiste Coudurier]

Hi Michael,

Michael Niedermayer wrote:
> On Fri, Apr 25, 2008 at 04:56:58PM +0200, Baptiste Coudurier wrote:
>> Hi,
>>
>> Several patches. I bet Michael will wonder how this got into svn ;)
>>
>> I tried to split it as much as I could and until I got too lazy.
>> This update will handle mp3on4 iso reference files publicly available.
>> When applying I'll be sure to split commits very carefully.
>> This standard defines 8khz mp3 which we were thinking about a long time ago.
>>
>> mp3on4_dec.patch is the full diff I have on my tree.
>>
>> Thanks for the review.
>>
>> [...]
>>  
>> -        if (ff_mpa_check_header(header) < 0) { // Bad header, discard block
>> -            *data_size = 0;
>> -            return buf_size;
>> -        }
>> +        if (ff_mpa_check_header(header) < 0) // Bad header, discard block
>> +            return -1
>>  
>>          ff_mpegaudio_decode_header(m, header);
>>          mp_decode_frame(m, decoded_buf, start, fsize);
> 
> This is incorrect, as some frames could have been decoded sucessfully
> i think and this would discard them.
> 

Yes, good point, handled it.

All parts applied. Thanks for the review.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312