[FFmpeg-devel] [PATCH] Common ACELP routines (3/3) - LPC decoding routines

[Vladimir Voroshilov]

On Sat, Apr 26, 2008 at 6:37 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>
> On Sat, Apr 26, 2008 at 02:18:17PM +0700, Vladimir Voroshilov wrote:
>  > Michael Niedermayer wrote:
>  > > On Fri, Apr 25, 2008 at 11:57:24PM +0700, Vladimir Voroshilov wrote:
>  > > > On 4/25/08, Vladimir Voroshilov <voroshil at gmail.com> wrote:
>  > > [...]
>  > > > > > also please change the Q12/15 notation to some normal fixed point one with
>  > > > > > min/one/max
>  > > > >
>  > > > > Like this?:
>  > > > >
>  > > > > /**
>  > > > >  * \param param1 bla bla bla
>  > > > > ...
>  > > > >  * \return some value
>  > > > >  *
>  > > > >  *  allowed values for param1:
>  > > > >  *   min: -0x10000
>  > > > >  *   max:  0x10000
>  > > > >  *   one   0x01000
>  > > > >  */
>  > > > >
>  > > > > Or something different?
>  > > > > Give me sample please.
>  > > >
>  > > > Waiting for answer.
>  > > > Currently kept Q[n] notation as is.
>  > >
>  > > [...]
>  > >
>  > > > +void ff_acelp_reorder_lsf(int16_t* lsfq, int lsfq_min_distance, int lsfq_min, int lsfq_max)
>  > > > +{
>  > > > +    int i, j;
>  > > > +
>  > > > +    /* sort lsfq in ascending order. float bubble agorithm, O(n)*/
>  > >
>  > > Its O(n) if already sorted otherwise its O(n^2)
>  >
>  > Fixed.
>  >
>  > > anyway the patch looks ok except this and the Q* notation
>  >
>  > I've added parenthesis to your suggestion to differ fixed-point value
>  > description from regular floating-point constant.
>  > I.e. description looks like (-0x8000 <= (0.15) < 0x8000)
>  > in parameters and just (0.15) in code's comments
>  >
>  > P.S. Suggested commit message: "Fixed-point LSP and LPC decoding routines for ACELP-based codecs"
>
>  ok

Applied.

-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719