[FFmpeg-devel] [PATCH] Add supported_samplerates field to AVCodec

[Michael Niedermayer]

On Mon, Apr 21, 2008 at 12:27:08AM +0200, Stefano Sabatini wrote:
> Hi,
> 
> as suggested in this thread:
> http://thread.gmane.org/20080407143527.GA15487 at geppetto
> 
> I'm not sure what is better if "supported_framerates" (more consistent
> with AVCodec.supported_framerates) or "supported_frame_rates" (more
> consistent with AVFrame.sample_rate).
> 
> Best regards.
> -- 
> FFmpeg =  Fucking & Fiendish MultiPurpose EnGine

> Index: libavcodec/avcodec.h
> ===================================================================
> --- libavcodec/avcodec.h	(revision 12912)
> +++ libavcodec/avcodec.h	(working copy)
> @@ -30,7 +30,7 @@
>  #include "libavutil/avutil.h"
>  
>  #define LIBAVCODEC_VERSION_MAJOR 51
> -#define LIBAVCODEC_VERSION_MINOR 55
> +#define LIBAVCODEC_VERSION_MINOR 56
>  #define LIBAVCODEC_VERSION_MICRO  0
>  
>  #define LIBAVCODEC_VERSION_INT  AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \
> @@ -2241,6 +2241,7 @@
>      const AVRational *supported_framerates; ///< array of supported framerates, or NULL if any, array is terminated by {0,0}
>      const enum PixelFormat *pix_fmts;       ///< array of supported pixel formats, or NULL if unknown, array is terminated by -1
>      const char *long_name;                  ///< descriptive name for the codec, meant to be more human readable than \p name

> +    const int *supported_samplerates;       ///< array of supported audio samplerates, or NULL if unknown, array is terminated by -1

i would prefer if the array where terminated by 0


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080421/ace3dd0e/attachment.pgp>