[FFmpeg-devel] [PATCH] Decrease score returned by wav_probe

[Vladimir Voroshilov]

On Sat, Apr 19, 2008 at 9:34 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sat, Apr 19, 2008 at 09:18:08PM +0700, Vladimir Voroshilov wrote:
>  > Hi, Michael
>  >
>  > On Sat, Apr 19, 2008 at 9:00 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>  > > On Sat, Apr 19, 2008 at 01:29:09PM +0700, Vladimir Voroshilov wrote:
>  > >  > Hi, All
>  > >  >
>  > >  > I've found recently that r12837 ("Do not detect a format if another
>  > >  > has the same score")
>  > >  > makes ACT format (uncommited, demuxer patch still pending in m/l for
>  > >  > G.729 decoder)
>  > >  > probing impossible .
>  > >  >
>  > >  > The reason is in standard WAV header placed at top of ACT's
>  > >  > This cause both ACT and WAV returns AVPROBE_SCORE_MAX which leads to
>  > >  > discarding probing results from both formats.
>  > >  >
>  > >  > Attached patch does tirival thing: decreases value returned by wav_probe by 1.
>  > >  > I'm not sure that this is correct solution, but can't see anything better.
>  > >  >
>  > >  > P.S. "make test" passed
>  > >
>  > >  patch ok, but please add a note why the score must be  < AVPROBE_SCORE_MAX
>  > >
>  >
>  > Is text in attached patch good enough?
>
>  yes
>

Applied.

-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719