[FFmpeg-devel] [PATCH] Patch cleanup for MPEG 1 & 2 optimizations

Keiji Costantini lists
Thu Apr 17 03:44:31 CEST 2008


Michael Niedermayer ha scritto:
> On Mon, Apr 14, 2008 at 10:53:42AM -0400, Jeff Downs wrote:
>> On Sun, 13 Apr 2008, Jeff Downs wrote:
>>
>>> MPV_motion_internal is no longer inlined (max-inline-insns-single limit 
>>> reached).  Trying to increase that limit to double the gcc man page stated 
>>> default did nothing to help. Limit was still reached.
>>>
>>> Adding av_always_inline to it makes it be inlined. MPV_motion is still not 
>>> (though I don't know if it is in current svn either).
>>> This (and fixing the aforementioned typo) gets performance closer to what 
>>> I posted for the hardcoded version.
>>>
>> OP's patches with the addition of av_always_inline to MPV_motion and 
>> fixing the typo in the calls to MPV_decode_mb are attached.
> 
> and what effect do the have on the object filesizes ?

The file in question is "libavcodec/mpegvideo.o" (renamed accordingly)

original:
1120k  vanilla.o
328k   vanilla2.o


with my last patch submitted:
1248k  patched.o
360k   patched2.o


with attached patch (roughly made inline things):
1052k  inline.o
308k   inline2.o

With the "-S" passed as argument and not (smaller is "not").
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Unroll-codepath-2.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080417/c0c04fea/attachment.asc>



More information about the ffmpeg-devel mailing list