[FFmpeg-devel] [PATCH] wrong time base for audio in AVI

Michael Niedermayer michaelni
Sat Apr 12 23:39:41 CEST 2008

On Sat, Apr 12, 2008 at 11:28:24PM +0200, Reimar D?ffinger wrote:
> On Sat, Apr 12, 2008 at 08:34:31PM +0200, Michael Niedermayer wrote:
> > On Sat, Apr 12, 2008 at 08:06:02PM +0200, Reimar D?ffinger wrote:
> > > Maybe, it is unclear to me what exactly is not behaving as intended,
> > > that assert in update_initial_durations is based on an awful lot of
> > > conditions/assumptions, e.g. that the result of compute_frame_duration
> > > fits into a time base. I just assumed that this assumption means that
> > > the audio time_base _always_ must be a "multiple" of the sample rate,
> > > otherwise I can't see how this should be able to guarantee for e.g.
> > > broken files.
> > 
> > What happens if we just dont call update_initial_durations() if duration==0?
> It fixes that file just as well, with no bad effects as far as I can

make test and if it passes commit!

> tell, though pkt->duration == 0 sounds unhealthy to me.

Well its the best it can be set to within the constrains ...


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080412/ae27ca33/attachment.pgp>

More information about the ffmpeg-devel mailing list