[FFmpeg-devel] [PATCH] BFI demuxer

[Michael Niedermayer]

On Sat, Apr 12, 2008 at 10:19:59PM +0530, Sisir Koppaka wrote:
> On Sat, Apr 12, 2008 at 10:16 PM, Sisir Koppaka <sisir.koppaka at gmail.com>
> wrote:
> 
> > On Sat, Apr 12, 2008 at 9:42 PM, Michael Niedermayer <michaelni at gmx.at>
> > wrote:
> >
> > > On Sat, Apr 12, 2008 at 09:15:57PM +0530, Sisir Koppaka wrote:
> > > > On Sat, Apr 12, 2008 at 9:07 PM, Michael Niedermayer <michaelni at gmx.at
> > > >
> > > > wrote:
> > > >
> > > > > On Sat, Apr 12, 2008 at 08:46:52PM +0530, Sisir Koppaka wrote:
> > > > > > +
> > > > > > +    return ret;
> > > > > > +}
> > > > > > +
> > > > > > +static int bfi_read_close(AVFormatContext * s)
> > > > > > +{
> > > > > > +    av_close_input_stream(s);
> > > > > > +    return 0;
> > > > > > +}
> > > > >
> > > > > buggy
> > > > >
> > > > I couldn't get what you meant here?
> > >
> > > i mean that the code above does not work, is not correct ...
> > >
> > Is this ok?
> > static int bfi_read_close(AVFormatContext *s)
> > {
> >     int i;
> >     AVStream *st;
> >     for(i = 0; i < 2; i++) {
> >         st = s->streams[i];
> >         if (st->parser) {
> >             av_parser_close(st->parser);
> >         }
> >         av_free(st->index_entries);
> >         av_free(st->codec->extradata);
> >         av_free(st->codec);
> >         av_free(st->filename);
> >         av_free(st);
> >      }
> >     av_freep(&s->priv_data);
> >     av_free(s);
> >     return 0;
> > }
> > -----------------
> > Sisir Koppaka
> >
> Removed the flush_packet_queue line, it's causing problems.

This code is still wrong

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080412/dba8e3ad/attachment.pgp>