[FFmpeg-devel] [PATCH]Add Dirac support to ffmpeg via libdirac_* and Schroedinger libraries]

[Diego Biurrun]

On Fri, Apr 11, 2008 at 12:12:11PM +1000, Anuradha Suraparaju wrote:
> 
> On Thu, 2008-04-10 at 11:44 +0200, Diego Biurrun wrote:
> 
> [...]
> 
> > > +    int num_formats = sizeof(ffmpeg_dirac_pixel_format_map)/sizeof(ffmpeg_dirac_pixel_format_map[0]);
> > 
> > Breaking long lines such as this one would be a plus.
> 
> Is there a common convention that is followed everywhere in ffmpeg
> regarding long lines? I usually like to keep connected info on one line
> even though it exceeds 80 chars because it make "grep"ping for code
> easier.

It is not followed everywhere - after all it has not been so long that
we enforce such things in reviews - but it is generally preferred to
keep lines below 80 characters where sensible.

The example above could be written as

  int num_formats = sizeof(ffmpeg_dirac_pixel_format_map) /
                    sizeof(ffmpeg_dirac_pixel_format_map[0]);

which is much more readable IMO.  The spaces around the / operator also
help me.

Diego