[FFmpeg-devel] [PATCH] eliminate long from ByteIOContext structure

[Michael Niedermayer]

On Wed, Apr 09, 2008 at 06:20:46PM +0200, Diego Biurrun wrote:
> On Thu, Apr 03, 2008 at 02:24:21AM +0200, Michael Niedermayer wrote:
> > On Thu, Apr 03, 2008 at 01:52:42AM +0200, Diego Biurrun wrote:
> > > 
> > > So how is it not a bug if the wrapper returns unsigned long, but the
> > > wrapped function returns uint32_t?
> > 
> > That has perfectly defined behavior in C, what you wrote though has not
> > and gcc should if it compiles it at all spew out warnings.
> 
> I get no extra warnings when compiling with the FFmpeg version number
> bumped.
> 
> Anyway, here is another iteration that hopefully makes you happy...

av_adler32_update() should be changed as well, but iam really not sure if all
that is worth it. there is nothing wrong with long and iam starting to think
its better if we leave it as it is.

[....]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080409/803964dd/attachment.pgp>