[FFmpeg-devel] Bink audio decoder
Wed Apr 9 16:09:41 CEST 2008
On Wed, Apr 09, 2008 at 11:47:32PM +1000, pross at xvid.org wrote:
> Enclosed is a working demuxer and audio decoder for the Bink multimedia
> format. The patch has been tested on PPC hardware only, but should run
Mike will be happy to hear about this...
> The audio codec makes use of a windowed real-value FFT (and DCT for more
> recent files). Benjamin L tells me that there are NO equivalent dsp
> routines in FFmpeg, so as a starting point a well known public domain
> routine is included.
Umm, see below.
This will likely get merged quicker if you split demuxer and decoder
into separate patches.
> + */
empty Doxygen comment? same above..
> +static int binkaudio_decode_frame(AVCodecContext *avctx, void *data, int *data_size, const uint8_t *buf, int buf_size)
You can earn extra good karma by splitting these long lines.
> --- libavcodec/avcodec.h (revision 12774)
> +++ libavcodec/avcodec.h (working copy)
> @@ -183,6 +183,7 @@
> + CODEC_ID_BINKVIDEO,
Did I miss something? You are not adding such a thing...
> --- libavcodec/fft4g.h (revision 0)
> +++ libavcodec/fft4g.h (revision 0)
> @@ -0,0 +1,1368 @@
> + Copyright(C) 1996-2001 Takuya OOURA
> + email: ooura at mmm.t.u-tokyo.ac.jp
> + download: http://momonga.t.u-tokyo.ac.jp/~ooura/fft.html
> + You may use, copy, modify this code for any purpose and
> + without fee. You may distribute this ORIGINAL package.
That sounds very much like vanilla distribution only. This is not
public domain and not LGPL-compatible.
More information about the ffmpeg-devel