[FFmpeg-devel] [PATCH] Complete argument information in ffmpeg.c:options for non number arguments

[Robert Swain]

On 07/04/2008, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sat, Apr 05, 2008 at 12:43:32AM +0200, Stefano Sabatini wrote:
>  > On date Friday 2008-04-04 16:09:20 +0200, Michael Niedermayer encoded:
>  > > On Fri, Apr 04, 2008 at 03:34:37PM +0200, Stefano Sabatini wrote:
>  > > > On date Friday 2008-04-04 13:37:56 +0200, Michael Niedermayer encoded:
>  > > > > On Fri, Apr 04, 2008 at 12:52:53PM +0200, Stefano Sabatini wrote:
>  > > > > > Hi,
>  > > > > >
>  > > > > > completes information regarding the description of the argument which
>  > > > > > is currently missing from the ffmpeg.c:options array.
>  > > > > >
>  > > > > > This should make clearer to the user reading the ffmpeg -h output if
>  > > > > > an option takes an argument and which is its type (although the option
>  > > > > > itself may be quite essoteric and undocumented in the man e.g. async,
>  > > > > > vsync, vglobal...).
>  > > > > >
>  > > > > > Best regards.
>  > > > > > --
>  > > > > > Stefano Sabatini
>  > > > > > Linux user number 337176 (see http://counter.li.org)
>  > > > >
>  > > > > > Index: ffmpeg.c
>  > > > > > ===================================================================
>  > > > > > --- ffmpeg.c  (revision 12684)
>  > > > > > +++ ffmpeg.c  (working copy)
>  > > > > > @@ -3745,22 +3745,22 @@
>  > > > > >        "when dumping packets, also dump the payload" },
>  > > > > >      { "re", OPT_BOOL | OPT_EXPERT, {(void*)&rate_emu}, "read input at native frame rate", "" },
>  > > > > >      { "loop_input", OPT_BOOL | OPT_EXPERT, {(void*)&loop_input}, "loop (current only works with images)" },
>  > > > > > -    { "loop_output", HAS_ARG | OPT_INT | OPT_EXPERT, {(void*)&loop_output}, "number of times to loop output in formats that support looping (0 loops forever)", "" },
>  > > > > > +    { "loop_output", HAS_ARG | OPT_INT | OPT_EXPERT, {(void*)&loop_output}, "number of times to loop output in formats that support looping (0 loops forever)", "number" },
>  > > > >
>  > > > > all additions of "number" are rejected
>  > > >
>  > > > Hi, what do you suggest insted?
>  > >
>  > > Split the patch.
>  >
>  > Attached patch for the non number argument names, but what I don't
>  > understand is if you want the other unspecified argument names (for
>  > async, vsync, vglobal, loop_output, programid, top) to be left
>  > unspecified or simply want an argument description more meaningful
>  > than "number".
>
> looks ok

Applied the 'split' patch.

Michael: should Stefano infer from your lack of response about the
others that they are to be left as is and you don't have any
suggestions?

Rob